Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned iris>=3.2.1 #1552

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Pinned iris>=3.2.1 #1552

merged 1 commit into from
Mar 28, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 22, 2022

As promised before the release, this PR removes the pin to iris<=3.1.0 and sets it to iris>=3.2.1 to allow the use of new features.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added installation Installation problem iris Related to the Iris package labels Mar 22, 2022
@schlunma schlunma added this to the v2.6.0 milestone Mar 22, 2022
@schlunma schlunma self-assigned this Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1552 (0124314) into main (99fbe3c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1552   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         197      197           
  Lines       10572    10572           
=======================================
  Hits         9596     9596           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fbe3c...0124314. Read the comment docs.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, Manu! shall we also have a build upgrade on the feedstock or you want the stable release to still be using the old pin for Tool to work correctly?

@schlunma
Copy link
Contributor Author

Cheers guys!

cheers, Manu! shall we also have a build upgrade on the feedstock or you want the stable release to still be using the old pin for Tool to work correctly?

I think it's better to use the old pin in the stable release for now, we still haven't extensively tested this new iris version!

@schlunma schlunma merged commit a5dbdc1 into main Mar 28, 2022
@schlunma schlunma deleted the unpin_iris branch March 28, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem iris Related to the Iris package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants